Skip to content

ci: cancel PR runs only for new commits - #569

Merged
uniqueg merged 1 commit into
devfrom
ci/gate-cancel-new-commits
Nov 11, 2026
Merged

ci: cancel PR runs only for new commits#569
uniqueg merged 1 commit into
devfrom
ci/gate-cancel-new-commits

Conversation

@uniqueg

@uniqueg uniqueg commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Only a new head commit of a pull request now cancels its CI runs in progress: cancel-in-progress of the workflow-level concurrency block in .github/workflows/ci.yml is true only for pull_request with action synchronize on the first attempt, as in "Cancelled runs" of actions/gate/README.md in elixir-cloud-aai/.github (elixir-cloud-aai/.github#71):

cancel-in-progress: >-
  ${{ github.event_name == 'pull_request'
  && github.event.action == 'synchronize'
  && github.run_attempt == 1 }}

Before, a newer run on the same commit (e.g. for editing the description, also by Sourcery, or marking the pull request ready) cancelled the run in progress, and its failed CI passed was then the newest result on the commit, which blocked the merge (elixir-cloud-aai/.github#70). Runs for other actions, and reruns, now wait for the run in progress instead; a waiting run that is replaced starts no job, so it leaves no check. The gate keeps if: always(), so a needed job that failed or was cancelled still fails it. This pull request's own runs already use the new rule.

The concurrency groups are unchanged (runs for pushes and for edits that leave the title unchanged keep groups of their own); the comment above the block now describes the new rule.

Part of elixir-cloud-aai/.github#73

Verification

  • actionlint and check-yaml (hooks of cloud-registry's pre-commit config, as this repository has none) on .github/workflows/ci.yml: passed.
  • CI: all checks passed, including CI passed, on 0cd95b6.
  • Sourcery: approved, no threads.

Light lane: changes only the CI workflow's concurrency settings (no secrets, permissions or release workflow); I reviewed the diff myself.

Declined review findings

None.

Open questions

None.

🤖 Generated with Claude Code

https://claude.ai/code/session_011FSoqMpmDCfbACLj3uy6xV

@uniqueg @claude
ci: cancel PR runs only for new commits
0cd95b6 
A newer run on the same commit (e.g. for an edit of the description)
cancelled the run in progress, and its failed gate then blocked the
merge. Only the first attempt of a run for a pull request's
synchronize action now cancels runs in progress, as in "Cancelled
runs" of actions/gate/README.md in elixir-cloud-aai/.github.

Part of elixir-cloud-aai/.github#73

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011FSoqMpmDCfbACLj3uy6xV
@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.40%. Comparing base (44c6f96) to head (0cd95b6).

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #569   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files          23       23           
  Lines        5655     5655           
  Branches      199      199           
=======================================
  Hits         4038     4038           
  Misses       1610     1610           
  Partials        7        7

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uniqueg
uniqueg marked this pull request as ready for review November 10, 2026 20:08
@uniqueg
uniqueg requested a review from anuragxxd as a code owner November 10, 2026 20:08
@sourcery-ai

sourcery-ai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Configuration

Restrict workflow-level cancellation to first-attempt pull-request synchronize runs, and update the comment to explain the rule.

  • .github/workflows/ci.yml L24-31, L39-42
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot approved these changes Nov 10, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@uniqueg
uniqueg merged commit 8c24d9b into dev Nov 11, 2026
31 checks passed
@uniqueg
uniqueg deleted the ci/gate-cancel-new-commits branch November 11, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes
@anuragxxd anuragxxd Awaiting requested review from anuragxxd anuragxxd is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@uniqueg